Fix rust 2024 warning when using nserde(skip) field annotations #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, the
#nserde(skip)
attribute on a struct with aderive(DeRon)
annotation would cause build warnings. You can see this by runningcargo test
in the project.From looking at the expanded macros, I think this is because in the generated code, type inference relies on the assignment of the local value to its corresponding struct field to know what the value of the type binding is. Because
skip()
skips this and replaces the value withDefault:;default()
, the resulting option type is initialized to the "lowest" possible type,Option<!>
.I think that makes the
DeSer::de_ron()
call to initialize the field values fall back to theDeSer
impl for()
, which triggers the compiler warning. Not 100% sure about that but either way, adding type annotations makes the warning go away!